Closed
Bug 547458
Opened 15 years ago
Closed 15 years ago
Modern theme needs CSS for about:memory
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: neil, Assigned: InvisibleSmiley)
References
()
Details
(Keywords: modern)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
InvisibleSmiley
:
review+
|
Details | Diff | Splinter Review |
Bug 520364 made it possible for themes to style about:memory
|
Assignee | |
Comment 1•15 years ago
|
||
I mostly just copy-pasted from mozilla/toolkit/components/aboutmemory/content/aboutMemory.css and Modern's about.css. I'm not a Modern expert.
|
Reporter | |
Updated•15 years ago
|
Attachment #441614 -
Flags: review?(neil) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
Comment on attachment 441614 [details] [diff] [review]
patch
r=me with a couple of nits fixed.
>+h1 {
>+ font-weight: bold;
>+ font-size: x-large;
>+}
Probably unnecessary; see below.
>+h2 {
>+ margin-top: 0;
>+ font-weight: bold;
>+ font-size: large;
>+}
The font-weight is of course unnecessary, since all headers default to bold. I don't see any advantage in changing the default sizes either. We probably need to keep the zero top margin though.
>+.memOverview table {
>+ font-size: 120%;
>+}
about.css uses 110% for something similar.
|
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 441614 [details] [diff] [review]
patch
>+.memOverview table {
.memOverview > table
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #441614 -
Attachment is obsolete: true
Attachment #443202 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: helpwanted
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 443202 [details] [diff] [review]
patch v2 [Checkin: comment 5]
http://hg.mozilla.org/comm-central/rev/475ee6344218
Attachment #443202 -
Attachment description: patch v2 → patch v2 [Checkin: comment 5]
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•