Closed
Bug 548193
Opened 15 years ago
Closed 14 years ago
Content Security Policy XML reports have escaping bugs, should probably use JSON anyway
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: sayrer, Assigned: bsterne)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Jonas and I talked this over with sstamm today. The csp-report documents are produced using string concatenation, leading to pretty much inevitable escaping bugs. We all agreed JSON is a better fit anyway. Use the built-in JSON.stringify method to get something correctly escaped.
site of bug:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/contentSecurityPolicy.js#250
|
Reporter | |
Updated•15 years ago
|
Assignee: nobody → sstamm
Agreed! XML is a horrible data container format. JSON is much easier to serialize/parse, and is more compact across the wire.
Stop the XML madness now!
|
||
Updated•15 years ago
|
Assignee: sstamm → bsterne
|
Assignee | |
Comment 2•14 years ago
|
||
I'll add a test for the new report format as well.
Attachment #447336 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #447336 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/373675ded180
http://hg.mozilla.org/mozilla-central/rev/6ec180ff146f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a5
Version: unspecified → Trunk
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•