Closed
Bug 548704
Opened 15 years ago
Closed 15 years ago
Plugin-problem UI should use browser locale direction, not the page's.
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 555289
People
(Reporter: Dolske, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The plugin-problem UI is localized by the browser, and should thus use the correct directionality. Eg, a LTR page in a Persian-locale Firefox should display the UI in RTL mode, while a RTL page in a English-locale Firefox should display the UI in LTR mode.
Attachment #429033 -
Flags: review?(ehsan.akhgari)
|
Reporter | |
Comment 1•15 years ago
|
||
(I have reftests for a separate bug to check this, though I'm not sure how to force browser RTL-mode to check that the UI is RTL in a LTR page. But LTR in a RTL page works with this page.)
|
|
Reporter | |
Comment 2•15 years ago
|
||
err, works with this *patch*. not page.
|
||
Comment 3•15 years ago
|
||
You need to have tests for this. You just have to set the intl.uidirection.en-US pref to "rtl" to turn the browser into RTL mode, do the test, and reset it to restore the status of the browser.
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 429033 [details] [diff] [review]
Patch v.1
r=me pending the tests.
Attachment #429033 -
Flags: review?(ehsan.akhgari) → review+
|
||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•