Closed
Bug 54963
Opened 24 years ago
Closed 24 years ago
Mousewheel font sizing not bounded
Categories
(SeaMonkey :: UI Design, defect, P3)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: sicking)
References
Details
(Keywords: arch)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
ctrl wheel down until you reach the smallest size.
one more gets you to a default size (I think you're at 0)
one more gets you to the smallest size (I think you're at -1)
continuing to wheel down sizes up.
Updated•24 years ago
|
QA Contact: sairuh → janc
Comment 1•24 years ago
|
||
Actually, this happens for zoom 1%, 2% and 3%. So it's not necessarily a matter
of the mousewheel not being bounded, rather our font zoom backend being weird.
I'll file a bug on that, mark this depending on it. I suspect the mousewheel is
bounded, at least at the lower end. We really should add the 5000% bound at the
upper end (it completely kills the X server to try anything larger on lower end
machines).
Accepting bug for now.
Status: NEW → ASSIGNED
Comment 3•24 years ago
|
||
Timeless: On which platforms did you test? What build?
pierre this was an arch issue, I was probably using windows (nt4 or w2k likely
w/ mstsc), but assuming you could wheel elsewhere the problem should have
occured there too. The bug was filed per jag.
Keywords: arch
Comment 5•24 years ago
|
||
And to answer the build question, knowing timeless, it was a late September,
early October trunk build.
Comment 6•24 years ago
|
||
cc'ing bryner... bryner, you probably put a lower bound (0) on this code, did
you put an upper bound in?
(I still have to find out where this code lives and have higher priority stuff
I'm working on, this one may be a lot easier to fix for you...)
Comment 7•24 years ago
|
||
The relevant section of code is in nsEventStateManager::ChangeTextSize
(layout/events/src/nsEventStateManager.cpp) -- simply add appropriate bounds
checking before calling SetTextZoom.
Please take a look at nasty little bug 61117 (and assign as appropriate.)
Comment 10•24 years ago
|
||
*** Bug 49674 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
I've attatched a patch that adds an upper and lower bound in
nsEventStateManager::ChangeTextSize.
Please review
Assignee | ||
Comment 13•24 years ago
|
||
*** Bug 64423 has been marked as a duplicate of this bug. ***
Comment 14•24 years ago
|
||
I think the Text Size menu's `other' item has a lower upper bound than that.
Can you make it the same?
Comment 15•24 years ago
|
||
Nevermind, you're right.
Comment 16•24 years ago
|
||
r=bryner
Assignee | ||
Comment 18•24 years ago
|
||
Comment 19•24 years ago
|
||
ben re-a='ed on irc. r=blake for the second patch. reassigning to jonas.
Assignee: disttsc → sicking
Status: ASSIGNED → NEW
Comment 20•24 years ago
|
||
Fix checked in. Thanks for the patch.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Summary: ctrl+Mouse wheel [font sizing] not bounded. → Mousewheel font sizing not bounded
Comment 21•24 years ago
|
||
Bug 61117 (marked dup of this) was not at all fixed by this.
2001-010517 trunk linux: Complete freeze for over 5 minutes after a "heavy"
scroll" downsizing. (P3/500) During this the cursor completely vanished after
some minutes of heavy disk activity, and never returned, even after a killall
mozilla-bin. Had to kill X and restart to get it back. (RH6.2 XFree86-3.3.6-20)
In addition: The old default for mousewheel resizing is gone (shift+scroll)
(shouldn't that be the default when no special settings are done in prefs?)
Comment 22•24 years ago
|
||
hmm and.. when i click advanced/mousewheel in prefs, console says moo!
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•