Closed Bug 550844 Opened 15 years ago Closed 14 years ago

Complete fixing up unit test for bug 526733 (installation of extensions via application/x-xpinstall type)

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a2

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

In bug 526733 we tried to get a unit test landing for testing out notification bars and other things relating to installations of extensions in content tabs via application/x-xpinstall types. We need to complete fixing up those tests and getting them to land. See comments 6 to 10 on that bug. Assigning to Andrew as he did the original mods.
Attached patch WIP (deleted) — Splinter Review
I took a brief look at this today, as I need to use the notificationbars in a different test... This patch is basically the same file as we originally landed with bug 526733, with the exception that there is a 55 millisecond sleep added at the end of install.xpi. It still fails occasionally on my setup, but a lot less with this in. My current theory is that either: - mozmill is trying to do stuff too soon after the modal xpinstall dialog or - the modal xpinstall dialog is blocking the notification going away until the modal dialog has cleared, and it just doesn't fire the AlertFired notification as a result.
Attachment #438710 - Flags: feedback?(bugmail)
(hence asking asuth what he thinks about this).
Please attach a log of the failure with your extra debug. It doesn't fail for me, and the log would simplify my analysis.
Attached file Log of failure (deleted) —
Here's the log of the failure with some added debugging, but don't let this get in the way of b2 stuff...
I've looked at this a bit, but I think this is one of those cases where we either: A) Need more data. or B) Need to just crank timeouts up. 'A' implies having bug 556848 resolved so we can get structured data out. B seems straightforward. rs=asuth to randomly add and increase timeouts as the situation demands.
Depends on: 556848
Attachment #438710 - Flags: feedback?(bugmail) → feedback+
Assignee: bugmail → bugzilla
Unit tests have moved to bug 571759 now that there's a revised add-on manager implementation.
Depends on: 571759
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: