Closed
Bug 550925
Opened 15 years ago
Closed 15 years ago
Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: bent.mozilla)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
dveditz
:
approval1.9.2.4+
dveditz
:
approval1.9.1.10+
|
Details | Diff | Splinter Review |
234 nsDOMWorkerTimeout::Init(JSContext* aCx, PRUint32 aArgc, jsval* aArgv,
248 PRUint32 interval;
249 if (aArgc > 1) {
250 if (!JS_ValueToECMAUint32(aCx, aArgv[1], (uint32*)&interval)) {
255 }
256 else {
if aArgc <= 1, interval is uninitialized
260 }
261
262 mInterval = interval;
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #431170 -
Flags: superreview?(jst)
Attachment #431170 -
Flags: review?(jst)
|
|
Assignee | |
Updated•15 years ago
|
Summary: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1 → Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1
|
||
Updated•15 years ago
|
Attachment #431170 -
Flags: superreview?(jst)
Attachment #431170 -
Flags: superreview+
Attachment #431170 -
Flags: review?(jst)
Attachment #431170 -
Flags: review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #431170 -
Flags: approval1.9.2.3?
Attachment #431170 -
Flags: approval1.9.1.10?
|
||
Comment 3•15 years ago
|
||
Comment on attachment 431170 [details] [diff] [review]
Patch
Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers
Attachment #431170 -
Flags: approval1.9.2.3?
Attachment #431170 -
Flags: approval1.9.2.3+
Attachment #431170 -
Flags: approval1.9.1.10?
Attachment #431170 -
Flags: approval1.9.1.10+
|
||
Comment 4•15 years ago
|
||
status1.9.2:
--- → .3-fixed
|
|
Assignee | |
Comment 5•15 years ago
|
||
status1.9.1:
--- → .10-fixed
|
|
||
Comment 6•15 years ago
|
||
Unless you landed this on the relbranch it's ".4-fixed"
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•