Closed
Bug 551397
Opened 15 years ago
Closed 15 years ago
CSS_PSEUDO_ELEMENT needs to be undefined before next definition
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Just noticed this build warning:
> nsCSSPseudoElements.cpp:58:1: warning: "CSS_PSEUDO_ELEMENT" redefined
> nsCSSPseudoElements.cpp:53:1: warning: this is the location of the previous definition
introduced by this changeset:
http://hg.mozilla.org/mozilla-central/diff/5b152f233117/layout/style/nsCSSPseudoElements.cpp
We just need to add an "#undef CSS_PSEUDO_ELEMENT" after the new #include.
|
Assignee | |
Comment 1•15 years ago
|
||
Here's the fix. Requesting r=sicking, even though he's not a style system peer, since it's in code he added and it's a trivial obviously-correct change.
Attachment #431570 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #431570 -
Flags: review? → review?(jonas)
Attachment #431570 -
Flags: review?(jonas) → review+
Comment on attachment 431570 [details] [diff] [review]
trivial fix
Doh! Thanks!
|
|
Assignee | |
Comment 3•15 years ago
|
||
no prob. :) pushed: http://hg.mozilla.org/mozilla-central/rev/db9f8b8aa122
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•