Closed
Bug 551569
Opened 15 years ago
Closed 4 years ago
Error when debugging macros can affect control flow
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: cjones, Unassigned)
References
Details
It's pretty easy to make this mistake
if (warning)
NS_WARNING("warning");
SomethingImportant();
In debug builds, this does the right thing, but in opt builds, that becomes
if (warning)
SomethingImportant();
Oops!
There's a site in dom/plugins/BrowserStreamChild.cpp where I did this, but it's hopefully being fixed by bsmedberg in some upcoming changes.
Reporter | ||
Comment 1•15 years ago
|
||
Actually, NS_WARNING() et al. prevent this from happening. But I still think it's a useful analysis. Not sure of the best problem definition and approach.
Updated•7 years ago
|
Product: Core → Firefox Build System
Comment 2•4 years ago
|
||
We have static-analysis for this right now.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•