Closed
Bug 552554
Opened 15 years ago
Closed 15 years ago
Remove ctypes dependency on nsILocalFile
Categories
(Core :: js-ctypes, defect, P1)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
People
(Reporter: dwitte, Assigned: dwitte)
References
Details
ctypes.open(libname) takes a string or nsILocalFile argument. Once we move ctypes into js/src, that's not kosher.
jorendorff suggested we could just try getting the 'persistentDescriptor' (I think?) property off the object, without needing a QI. That'd be a super easy workaround.
We have to be careful about opening the library, though. The nsILocalFile implementation uses PR_LoadLibraryWithFlags() on Windows, I think. Which ended up being important.
Assignee | ||
Comment 1•15 years ago
|
||
P1, need this for 1.9.3. Let's drop nsILocalFile altogether. Probably want to provide hooks so embeddors can specify how to open a library. Gecko would just use PR_LoadLibraryWithFlags or something.
Priority: -- → P1
Assignee | ||
Comment 2•15 years ago
|
||
Fixed by bug 538324.
Assignee: nobody → dwitte
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•