Closed
Bug 552619
Opened 15 years ago
Closed 15 years ago
gfxWindowsPlatform.h -- error C2143 and error C4430 Build failure after Bug 502906 landing
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Filing a new bug to track the issue from Bug 502906 Part 3
(In reply to Bug 502906 comment #36)
> I'm getting this build error.
>
> Building deps for /c/t1/hg/comm-central/mozilla/gfx/thebes/src/gfxRect.cpp
> cl -FogfxRect.obj -c -DIMPL_THEBES -DWOFF_MOZILLA_CLIENT
> -DMOZILLA_INTERNAL_API -DMOZ_SUITE=1 -DOSTYPE=\"WINNT5.1\" -DOSARCH=WINNT
> -I/c/t1/hg/comm-central/mozilla/gfx/thebes/src -I. -I../../../dist/
> include -I../../../dist/include/nsprpub
> -Ic:/t1/hg/objdir-sm/mozilla/dist/include/nspr
> -Ic:/t1/hg/objdir-sm/mozilla/dist/include/nss -GR- -TP -nologo
> -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -O1
> -Ic:/t1/hg/objdir-sm/mozilla/dist/include/cairo -MD -FI
> ../../../dist/include/mozilla-config.h -D
> MOZILLA_CLIENT /c/t1/hg/comm-central/mozilla/gfx/thebes/src/gfxRect.cpp
> ../../../dist/include\gfxWindowsPlatform.h(185) : error C2143: syntax error :
> missing ';' before '*'
> ../../../dist/include\gfxWindowsPlatform.h(185) : error C4430: missing type
> specifier - int assumed.
> Note: C++ does not support default-int
> ../../../dist/include\gfxWindowsPlatform.h(185) : error C4430: missing type
> specifier - int assumed.
> Note: C++ does not support default-int
> ../../../dist/include\gfxWindowsPlatform.h(185) : warning C4183:
> 'FindFontFamily': missing return type; assumed to be a member function
> returning 'int'
> make[7]: *** [gfxPlatform.obj] Error 2
|
Assignee | |
Comment 1•15 years ago
|
||
Is this sufficient to fix the breakage?
Assignee: nobody → jfkthame
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 432764 [details] [diff] [review]
ensure gfxFont.h is #included by gfxWindowsPlatform.h
This is needed in case dwrite is not available.
Attachment #432764 -
Flags: review?(bas.schouten)
|
||
Updated•15 years ago
|
Attachment #432764 -
Flags: review?(bas.schouten) → review+
|
Reporter | |
Comment 3•15 years ago
|
||
(In reply to comment #1)
> Created an attachment (id=432764) [details]
>
> Is this sufficient to fix the breakage?
Yes. WFM Here with patch. (did not run testsuite locally though)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed the fix to trunk:
http://hg.mozilla.org/mozilla-central/rev/3d5c61f80727
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•