Closed Bug 552714 Opened 15 years ago Closed 15 years ago

[mozmill] Failure in testCheckAboutPrivateBrowsing.js regarding SUMO URL.

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-test-failure][mozmill-doc-complete])

Attachments

(1 file)

Patch v1 (default)
(deleted), patch
u279076
: review+
Details | Diff | Splinter Review
could not validate element ID: urlbar with value http://support.mozilla.com/en-US/kb/Private+Browsing?style_mode=inproduct&as=u http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/e9f6337a312311dfa6f6005056a533eb We will have to use the correct URL to check. In favor of our efforts to have lesser external content I wonder if we can change the target url when clicking on the more info link in the about:privatebrowsing page. Ehsan, is that a pref we can modify for the mozmill test?
So, I took a look at the test, and I think this is the wrong way to test things. You should just test to make sure that another page has been loaded, the exact URL should not be hardcoded.
Correct, that's why I have to know how the URL gets constructed. Is there a pref you read when the link gets clicked? I can't find something specific in the code.
We format app.support.baseURL and append "private-browsing" to it.
Whiteboard: [mozmill-test-failure]
Attached patch Patch v1 (default) (deleted) — — Splinter Review
Thanks Ehsan. That works. Given that we can use the URL formatting on different places, I have also created a new helper function inside the UtilsAPI.
Attachment #434852 - Flags: review?(anthony.s.hughes)
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-doc-needed]
Attachment #434852 - Flags: review?(anthony.s.hughes) → review+
Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/485fc728188f http://hg.mozilla.org/qa/mozmill-tests/rev/236923979803
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Had to land a short follow-up just to match our coding style for parameters: http://hg.mozilla.org/qa/mozmill-tests/rev/4ce1bfcf1b28 http://hg.mozilla.org/qa/mozmill-tests/rev/aca03c3eaa2f
Whiteboard: [mozmill-test-failure][mozmill-doc-needed] → [mozmill-test-failure][mozmill-doc-complete]
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Private Browsing → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: private.browsing → mozmill-tests
Version: 3.5 Branch → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: