Closed
Bug 552759
Opened 15 years ago
Closed 14 years ago
Fix browser_signed_untrusted.js
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: mossop)
References
()
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•15 years ago
|
||
I couldn't see any litmus tests for signed extensions, it's probably worthwhile having a manual test for those in addition to the automated as the UI is important and it is a case rarely hit by nightly testers.
Flags: in-testsuite?
Flags: in-litmus?
Comment 2•15 years ago
|
||
Can you point me to some specs I can read to get familiar with it? That's not correlated to the website certificate, right?
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•15 years ago
|
||
Signed extensions tell the user the XPI has not been tampered with since it was signed by someone they trust. Few extensions implement it, but thinkgs like Google Toolbar and I think LinkedIn show up the name of the signer during the install process. I need to provide some examples of cases where the signing is broken in some way too.
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/projects/addonsmgr/rev/32d8dc3a73bc adjusts the test so that it allows untrusted signers to just appear as if the XPI was unsigned, this is ok for now I think.
Flags: in-testsuite? → in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Assignee | ||
Comment 5•14 years ago
|
||
JS code can't tell the difference between an unsigned XPI and one signed by an untrusted cert. I don't think there is much difference between the two as far as a user is concerned and dveditz agrees so this just makes the test check that the untrusted XPI appears as unsigned.
Attachment #435781 -
Flags: review?(robert.bugzilla)
Updated•14 years ago
|
Attachment #435781 -
Flags: review?(robert.bugzilla) → review+
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Assignee | ||
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/28bc763566de
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-litmus? → in-litmus-
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•