Closed
Bug 552934
Opened 15 years ago
Closed 15 years ago
Fix leak in Windows 7 jumplists implementation
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
implement a partial cycle collection.
|
Assignee | |
Updated•15 years ago
|
Summary: Fix leak in jumplists implementation → Fix leak in Windows 7 jumplists implementation
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #433044 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #433044 -
Flags: review? → review?(jmathies)
|
||
Comment 2•15 years ago
|
||
I guess r+ Marco? Clearly looks like something I left out of the original impl., can you explain why this is needed?
|
|
Assignee | |
Comment 3•15 years ago
|
||
see https://bugzilla.mozilla.org/show_bug.cgi?id=545228#c8
unfortunatly i don't know xpcom/js internals enough to follow the full cycle, i suspect it's a cycle with the jswrappers, we create 2 instances in that scope and like them toghether.
|
|
Assignee | |
Comment 4•15 years ago
|
||
*link them*
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 433044 [details] [diff] [review]
patch v1.0
I see, so when garbage collection runs on the jump list item, this insures the handler app that was created goes with it. My mistake from the original landing.
Attachment #433044 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
You need to log in
before you can comment on or make changes to this bug.
Description
•