Closed
Bug 553094
Opened 15 years ago
Closed 15 years ago
Support extension metadata in prefs
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•15 years ago
|
||
Dave, can you please give a bit more details on that bug?
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
|
Assignee | |
Comment 4•15 years ago
|
||
Also the follow-up fix http://hg.mozilla.org/projects/addonsmgr/rev/e191e8d803fc
|
|
Assignee | |
Comment 5•15 years ago
|
||
Adds the proepr localization handling and tests.
Attachment #435786 -
Flags: review?(robert.bugzilla)
|
||
Comment 6•15 years ago
|
||
Comment on attachment 435786 [details] [diff] [review]
patch rev 1
>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>@@ -62,6 +62,7 @@ const PREF_EM_CHECK_COMPATIBILITY =
> const PREF_EM_CHECK_UPDATE_SECURITY = "extensions.checkUpdateSecurity";
> const PREF_EM_UPDATE_URL = "extensions.update.url";
> const PREF_EM_ENABLED_ITEMS = "extensions.enabledItems";
>+const PREF_EM_EXTENSION_FORMAT = "extensions.%ID%.";
> const PREF_XPI_ENABLED = "xpinstall.enabled";
> const PREF_XPI_WHITELIST_REQUIRED = "xpinstall.whitelist.required";
>
>@@ -3961,11 +3962,43 @@ function AddonWrapper(addon) {
> });
>
> PROP_LOCALE_SINGLE.forEach(function(prop) {
>- this.__defineGetter__(prop, function() addon.selectedLocale[prop]);
>+ this.__defineGetter__(prop, function() {
>+ if (addon.active) {
>+ try {
>+ let pref = PREF_EM_EXTENSION_FORMAT.replace(/%ID%/, addon.id) + prop;
seems like this should just append the add-on ID and the '.' here and elsewhere
other than that looks good
Attachment #435786 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Comments addressed
Attachment #435786 -
Attachment is obsolete: true
Attachment #437336 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Comment 8•15 years ago
|
||
Comment on attachment 437336 [details] [diff] [review]
patch rev 2
Already reviewed
Attachment #437336 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 9•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Comment 10•15 years ago
|
||
Marking as verified fixed based on check-in and passing automated tests.
Status: RESOLVED → VERIFIED
|
||
Comment 11•14 years ago
|
||
I had to disable the last part of this test on Mac because it was failing on Tinderboxes:
http://hg.mozilla.org/mozilla-central/rev/e57dc7264ff5
I filed bug 615443 about that.
You need to log in
before you can comment on or make changes to this bug.
Description
•