Dave Townsend [:mossop] Assignee
	Description • 14 years ago

      No description provided.

	Dave Townsend [:mossop] Assignee
	Comment 1 • 14 years ago

http://hg.mozilla.org/projects/addonsmgr/rev/adfa6cfa9d81

	Dave Townsend [:mossop] Assignee
	Comment 2 • 14 years ago

Adds update checking for the current lightweight theme to match what happens on trunk. May want to switch this to using the new API properly in the future.

	Robert Strong (they/them - no direct email)
	Comment 3 • 14 years ago

Comment on attachment 435765 [details] [diff] [review]
Perform update check for the current lightweight theme

>diff --git a/toolkit/mozapps/extensions/LightweightThemeManager.jsm b/toolkit/mozapps/extensions/LightweightThemeManager.jsm
>--- a/toolkit/mozapps/extensions/LightweightThemeManager.jsm
>+++ b/toolkit/mozapps/extensions/LightweightThemeManager.jsm
>@@ -129,26 +129,26 @@ var LightweightThemeManager = {
>                                      JSON.stringify(aData));
> 
>     if (aData) {
>-      let theme = this.getUsedTheme(aData.id);
>-      // TODO detect if it is an install and act accordingly
>-      if (!theme) {
>+      var theme = this.getUsedTheme(aData.id);
>+      var isInstall = !theme || theme.version != aData.version;
Why the switch from let to var? Looks like both of these could be let

>+      if (isInstall) {
>+        var oldWrapper = theme ? new AddonWrapper(theme) : null;
>         var wrapper = new AddonWrapper(aData);
>         AddonManagerPrivate.callInstallListeners("onExternalInstall", null,
>-                                                 wrapper, null, false);
>+                                                 wrapper, oldWrapper, false);
>         AddonManagerPrivate.callAddonListeners("onInstalling", wrapper, false);
>       }
>+

	Dave Townsend [:mossop] Assignee
	Comment 4 • 14 years ago

Comments addressed

	Dave Townsend [:mossop] Assignee
	Comment 5 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/5fea6417c8f2

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 6 • 14 years ago

Does it mean updates can not be checked manually via the UI or is the context menu entry just disabled for now? If it's the latter case I would file a new bug.

	Dave Townsend [:mossop] Assignee
	Comment 7 • 14 years ago

(In reply to comment #6)
> Does it mean updates can not be checked manually via the UI or is the context
> menu entry just disabled for now? If it's the latter case I would file a new
> bug.

We're not going to offer users the ability to check for updates to personas.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 8 • 14 years ago

Verified fixed based on check-in and passing automated tests.