Closed Bug 553135 Opened 15 years ago Closed 14 years ago

Fix the leaks in extInstallTrigger.cpp

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

patch rev 1
(deleted), patch
Details | Diff | Splinter Review 
      No description provided.
Fixed in http://hg.mozilla.org/projects/addonsmgr/rev/5f6148738ea8

This is automatically tested by the leak detection on the browser chrome tests
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-review]
Status: NEW → ASSIGNED
Attached patch patch rev 1 (deleted) — — Splinter Review 
Makes sure to release the new strings we create.
Attachment #435790 - Flags: review?(robert.bugzilla)
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Comment on attachment 435790 [details] [diff] [review]
patch rev 1

Talked with Dave and he is going to add this to the xpinstall patch in bug 553169.
Attachment #435790 - Flags: review?(robert.bugzilla)
Blocks: 553169
No longer blocks: 461973
Landed on trunk as a part of bug 553169
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Dave, has the extInstallTrigger.cpp file be removed from the tree? MXR can't find it anymore.
The file got later renamed to amInstallTrigger.cpp
Thanks Dave. Now I can see the checked-in code. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: