Example: http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1269094699.1269096416.13784.gz&fulltext=1 Linux comm-central-trunk debug test mochitest-other on 2010/03/20 07:18:19 { Running chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js... Chrome file doesn't exist: /builds/slave/comm-central-trunk-linux-debug-unittest-mochitest-other/build/mochitest/browser/toolkit/content/tests/browser/head.js JS Component Loader: WARNING chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js:43 interface is a reserved identifier JS Component Loader: WARNING chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js:45 interface is a reserved identifier JS Component Loader: WARNING chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js:45 interface is a reserved identifier TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services object exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prefs exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prefs is an nsIPrefBranch2 TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prefs exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prefs is an nsIPrefService TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.wm exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.wm is an nsIWindowMediator TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.perms exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.perms is an nsIPermissionManager TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.io exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.io is an nsIIOService TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.io exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.io is an nsIIOService2 TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.appinfo exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.appinfo is an nsIXULAppInfo TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.appinfo exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.appinfo is an nsIXULRuntime TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.dirsvc exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.dirsvc is an nsIDirectoryService TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.dirsvc exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.dirsvc is an nsIProperties TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prompt exists TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.prompt is an nsIPromptService JavaScript strict warning: chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js, line 60: reference to undefined property Ci.nsIBrowserSearchService TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Services.search exists JavaScript strict warning: file:///builds/slave/comm-central-trunk-linux-debug-unittest-mochitest-other/build/seamonkey/modules/XPCOMUtils.jsm, line 272: reference to undefined property Cc[aContract] NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_Services.js | Exception thrown at file:///builds/slave/comm-central-trunk-linux-debug-unittest-mochitest-other/build/seamonkey/modules/XPCOMUtils.jsm:272 - TypeError: Cc[aContract] is undefined } 3 'JS Component Loader: WARNING' 2 'JavaScript strict warning' 1 'TEST-UNEXPECTED-FAIL'

Is this because of the search service getter? Feel free to file a bug on making that part of services.jsm (and its test) dependent on MOZ_TOOLKIT_SEARCH.

(In reply to comment #1) Yes, I assume this is the cause of the test failure. This is the bug to fix them.

Search is very likely the cause of the failure, as we don't ship/build the toolkit search service in SeaMonkey - yet. What is the "Chrome file doesn't exist:" about head.js?

(In reply to comment #3) > What is the "Chrome file doesn't exist:" about head.js? I wondered too: it was added in http://hg.mozilla.org/mozilla-central/rev/908b22d8fefe Excise nsCachedChromeChannel fixing bug 206691 amongst others In any case, this can be ignored wrt this bug.

Not blocking 1.9.3.

I chose to go with the route of invoking the Preprocessor here. If you would rather me split out the test I'll do that instead. I think this way is much more clear though.

Missed a needed addition to the Makefile.in's

Comment on attachment 448252 [details] [diff] [review] v2 >diff --git a/toolkit/content/tests/browser/Makefile.in b/toolkit/content/tests/browser/Makefile.in >+libs:: $(_BROWSER_PP_TEST_FILES) >+ $(EXIT_ON_ERROR) \ >+ for i in $^; do \ >+ dest=$(DEPTH)/_tests/testing/mochitest/browser/`basename $$i`; \ This doesn't work - $dest needs to include $(relativesrcdir). Did you test this patch?

This should actually do it. Tested too.

if ("nsIBrowserSearchService" in Ci) checkService("search", Ci.nsIBrowserSearchService); ? Preprocessing tests means that you need to rebuild when changing them, which you don't need to right now...

(In reply to comment #10) > Preprocessing tests means that you need to rebuild when changing them, which > you don't need to right now... Correct, but I don't think this will be a large problem in practice. This test checks for the existence of "search" so I can't do a feature test without regressing the test. I don't think its worth duplicating nearly the whole test for this one check. So I'm left with preprocessing. If gavin wants one of the other options, I'm open to changing it though. It is also done elsewhere already: * http://mxr.mozilla.org/mozilla-central/source/toolkit/components/ctypes/tests/Makefile.in#79 * http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/Makefile.in#107 * http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/chrome/Makefile.in#98

(In reply to comment #11) > This test checks for the existence of "search" so I can't do a feature test > without regressing the test. > > I don't think its worth duplicating nearly the whole test for this one check. I don't understand what this means. Would the code from comment 10 not work?

This should do it, per IRC gavin preferred Dao's version.