Closed
Bug 553993
Opened 15 years ago
Closed 14 years ago
XML Parsing Error: undefined entity, netError.xhtml, cspFrameAncestorBlocked.title
Categories
(Thunderbird :: Security, defect)
Thunderbird
Security
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mkmelin
:
review+
clarkbw
:
ui-review+
|
Details | Diff | Splinter Review |
We're getting this on trunk builds:
XML Parsing Error: undefined entity
Location: jar:file:///Users/mark/Downloads/Shredder.app/Contents/MacOS/chrome/toolkit.jar!/content/global/netError.xhtml
Line Number 316, Column 45: <h1 id="et_cspFrameAncestorBlocked">&cspFrameAncestorBlocked.title;</h1>
--------------------------------------------^
We need to port the strings from bug 515458 once we've branched.
Assignee | ||
Comment 2•15 years ago
|
||
Note bug 556946 says the error is:
XML Parsing Error: undefined entity
Location:
jar:file:///F:/Software/Kommunikation/Thunderbird/3.2-Branch/Nightly/chrome/toolkit.jar!/content/global/netError.xhtml
Line Number 60, Column 12: <title>&loadError.label;</title>
-----------^
Whatever the error is, we need to fix the net error strings to include the missing ones.
Comment 3•15 years ago
|
||
I'm getting the same in latest SeaMonkey nightlys (with http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/2010-05-04-00-comm-central-trunk-l10n/seamonkey-2.1a1pre.cs.linux-i686.tar.bz2 in particular).
Assignee | ||
Comment 4•14 years ago
|
||
This patch adds the missing entities to our override of netError.dtd.
Bryan: I've use the same wording as Firefox, as I think we're fine to do that for the new content security policy (this was added in bug 515458).
Assignee: nobody → bugzilla
Attachment #450102 -
Flags: ui-review?(clarkbw)
Attachment #450102 -
Flags: review?(mkmelin+mozilla)
Comment 5•14 years ago
|
||
Comment on attachment 450102 [details] [diff] [review]
The fix
Looks good to me; r=mkmelin
Attachment #450102 -
Flags: review?(mkmelin+mozilla) → review+
Comment 6•14 years ago
|
||
Comment on attachment 450102 [details] [diff] [review]
The fix
ui-r=me as this looks pretty straight forward
Attachment #450102 -
Flags: ui-review?(clarkbw) → ui-review+
Assignee | ||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs branch]
Target Milestone: --- → Thunderbird 3.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•