Closed Bug 554061 Opened 15 years ago Closed 15 years ago

menu is gray out before mouse-over

Categories

(Core :: CSS Parsing and Computation, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.3a4

People

(Reporter: bugmozz, Assigned: mstange)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screenshot before/after mouse-over (deleted) —
maybe regression by bug 538187 and/or bug 508482
Keywords: regression
Blocks: 538187, 508482
The menus are greyed out on startup using the default theme. Mousing over them will put them back into the normal state.
Customize Toolbar and Done, make them into the normal state
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Yes Alice that is true, but you have to do it everytime you restart Minefield.
Also, the menu bar is not highlighted ever with any other theme.
This just showed up in shredder too. Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100322 Shredder/3.2a1pre
I'm not sure what to do here. We don't restyle the document because HasDocumentStateDependentStyle doesn't find the :-moz-window-inactive rule because it's in an XBL stylesheet. For normal content state changes we can inspect XBL stylesheets because we can get the binding from the content node (in nsBindingManager::WalkRules), but when the document state changes we only have the root node and no way of getting to the right binding. Does this mean we'll have to iterate over the whole content tree whenever the document state changes?
I think this is toolkit bug. (and also in seamonkey 2.1 nightlies)
View Source window is also affected and exhibits the same behavior.
Component: General → Menus
QA Contact: general → menus
Component: Menus → Style System (CSS)
Product: Firefox → Core
QA Contact: menus → style-system
(In reply to comment #6) > I'm not sure what to do here. We don't restyle the document because > HasDocumentStateDependentStyle doesn't find the :-moz-window-inactive rule > because it's in an XBL stylesheet. For normal content state changes we can > inspect XBL stylesheets because we can get the binding from the content node > (in nsBindingManager::WalkRules), but when the document state changes we only > have the root node and no way of getting to the right binding. > > Does this mean we'll have to iterate over the whole content tree whenever the > document state changes? It seems like we'd only have to iterate over all XBL binding style sheets in the document... and that the binding manager itself could coalesce all the document state bits into one for all of them. We'd probably need a different WalkRuleProcessors mechanism to do this, though.
As i noted in bug 554574, the gray text only changes permanently to black if the window is in the foreground. if you have two windows and the one in the background has its menu mouse-over'd it will go back to gray
Attached patch v1 (deleted) — Splinter Review
Attachment #434724 - Flags: review?(dbaron)
Attachment #434724 - Flags: review?(dbaron) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Darn, I was hoping this would fix the problem with themes other than default, but it does not. Any chance of that happening or do all the themes need to be changed?
All themes need to be changed. Sorry for that.
(In reply to comment #17) > All themes need to be changed. Sorry for that. Something we should mention on MDC, or?
Keywords: dev-doc-needed
Bug 508482 needs to be documented, not this bug, as far as I can see.
Keywords: dev-doc-needed
Keywords: dev-doc-needed
Keywords: dev-doc-needed
(In reply to comment #5) > This just showed up in shredder too. Verified fixed in Shredder 3.2a1pre and SeaMonkey 2.1a1pre nightly builds. [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100326 SeaMonkey/2.1a1pre]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: