Closed
Bug 554202
Opened 15 years ago
Closed 14 years ago
Crash due to too much recursion in nsSMILInstanceTime::BreakPotentialCycle
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: birtles)
References
Details
(Keywords: crash, testcase)
Attachments
(2 files)
|
(deleted),
image/svg+xml
|
Details | |
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
testcase (crashes Firefox when loaded)
No description provided.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → birtles
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
Proposed patch.
There are three issues with the existing codebase:
1) The way we try to manage certain types of cycles is flawed as attachment 434902 [details] [diff] [review] demonstrates. Ironically, if there is such a cycle we jump right in and follow it forever. (Included as crashtest/554202-1.svg)
2) Even if we didn't get caught up in (1) we're still not actually breaking the cycles (as demonstrated by added crashtest/554202-2.svg)
3) There's some indeterminancy in how we prioritise animations in such cycles (as demonstrated by added reftest sandwich-priority-12.svg)
This patch fixes the above.
Attachment #447450 -
Flags: review?(roc)
Attachment #447450 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
||
Comment 3•14 years ago
|
||
Is this fixed now?
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Is this fixed now?
Yes, fixed. I was just waiting to make sure there were no problems with the build before marking the bug.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•