Closed Bug 554380 Opened 15 years ago Closed 15 years ago

[shared module] Update SearchAPI to match latest requirements

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-doc-complete])

Attachments

(3 files, 2 obsolete files)

Patch v2 [checked-in]
(deleted), patch
u279076
: review+
Details | Diff | Splinter Review
Patch v1 (mozilla1.9.1)
(deleted), patch
u279076
: review+
Details | Diff | Splinter Review
Follow-up patch
(deleted), patch
u279076
: review+
Details | Diff | Splinter Review
We have to update the SearchAPI so it will behave the same way as all the other shared modules for Mozmill tests. I will work on this immediately so we can fix the broken tests in this sub group.
What is "the SearchAPI"?
Blocks: 554381
Blocks: 554385
Blocks: 554391
Blocks: 554393
No longer blocks: 554393
Testing / Mozmill is probably a better place for working on shared libraries.
Assignee: hskupin → nobody
Component: Search → Mozmill
Depends on: 555347
Product: Firefox → Testing
QA Contact: search → mozmill
Attached patch Patch v1 (default) (obsolete) (deleted) — — Splinter Review
This is a complete rewrite of the API. I also had to update the SessionStoreAPI so I can move the tree functions to its own module. Looks like that the changes have fixed all broken tests. Please verify it at least by running it on your Linux box, Anthony.
Assignee: nobody → hskupin
Attachment #435763 - Flags: review?(anthony.s.hughes)
Attached patch Patch v1.1 (default) (obsolete) (deleted) — — Splinter Review
Sorry, forgot to update the example test.
Attachment #435763 - Attachment is obsolete: true
Attachment #435766 - Flags: review?(anthony.s.hughes)
Attachment #435763 - Flags: review?(anthony.s.hughes)
Comment on attachment 435766 [details] [diff] [review] Patch v1.1 (default) Let me add some more functions for the engine manager.
Attachment #435766 - Flags: review?(anthony.s.hughes)
Depends on: 555938
Attached patch Patch v2 [checked-in] (deleted) — — Splinter Review
This one contains all necessary helper functions for remaining Mozmill tests in the search category. It also has a workaround for bug 555938.
Attachment #435766 - Attachment is obsolete: true
Attachment #435882 - Flags: review?(anthony.s.hughes)
Blocks: 555991
Blocks: 555993
Blocks: 555994
Blocks: 555996
Comment on attachment 435882 [details] [diff] [review] Patch v2 [checked-in] Code looks fine, all tests pass, no regressions found. r+
Attachment #435882 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 435882 [details] [diff] [review] Patch v2 [checked-in] Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/98b84478dfb9
Attachment #435882 - Attachment description: Patch v2 → Patch v2 [checked-in]
Attached patch Patch v1 (mozilla1.9.1) (deleted) — — Splinter Review
Some updates were necessary for 1.9.1. I would feel better if you could also run a test.
Attachment #436169 - Flags: review?(anthony.s.hughes)
(In reply to comment #9) > Created an attachment (id=436169) [details] > Patch v1 (mozilla1.9.1) > > Some updates were necessary for 1.9.1. I would feel better if you could also > run a test. I'm unable to check against 1.9.1 due to an issue I'm having with Mozmill on 1.9.1. I can't seem to run any tests without python crashing. This issue is under investigation. If you need this reviewed anytime in the near future, I suggest finding someone else to do it.
Nevermind...I think I have it fixed...
Comment on attachment 436169 [details] [diff] [review] Patch v1 (mozilla1.9.1) Run against Firefox 3.5.8, all tests pass, r+
Attachment #436169 - Flags: review?(anthony.s.hughes) → review+
Landed remaining changes on the 1.9.1 branch: http://hg.mozilla.org/qa/mozmill-tests/rev/b44dc9e76b5e Documentation will happen next week.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-doc-needed]
Whiteboard: [mozmill-doc-needed] → [mozmill-doc-complete]
During the documentation I have noticed that some smaller things slipped through the review process. Let's fix it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Follow-up patch (deleted) — — Splinter Review
Attachment #438474 - Flags: review?(anthony.s.hughes)
Attachment #438474 - Flags: review?(anthony.s.hughes) → review+
Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/b502b27bbebf http://hg.mozilla.org/qa/mozmill-tests/rev/68a452f4caaf
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill → Mozmill Tests
Product: Testing → Mozilla QA
QA Contact: mozmill → mozmill-tests
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: