Closed
Bug 554417
Opened 15 years ago
Closed 15 years ago
[mozmill] Fix broken test testRemoveCookie.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression, Whiteboard: [mozmill-test-failure])
Attachments
(2 files)
|
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
With Firefox 3.5.x this test fails because we do not have access to the view of a tree. I know this has been worked before so I wonder what happened.
We will need to fix bug 554416. This will hopefully also fix this failure.
|
Assignee | |
Comment 1•15 years ago
|
||
Even with this failure fixed we will have to make sure the dialog gets closed. Right now it stays open after a failure happened.
|
|
Assignee | |
Comment 2•15 years ago
|
||
This failure is not related to bug 554416. Was able to fix that. Patch upcoming.
|
|
Assignee | |
Comment 3•15 years ago
|
||
This fixes the broken assertJS call and uses a try/catch/finally clause to make sure the cookie window is closed if a failure happens.
A patch against the default branch will follow soon.
Attachment #434386 -
Flags: review?(anthony.s.hughes)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #434389 -
Flags: review?(anthony.s.hughes)
Attachment #434386 -
Flags: review?(anthony.s.hughes) → review+
Attachment #434389 -
Flags: review?(anthony.s.hughes) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/5abdbc22cb8e
http://hg.mozilla.org/qa/mozmill-tests/rev/8c6addfd74a1
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•15 years ago
|
||
I accidentally used the same bug id for the checkin comment for the patches on bug 554506. I just mention it here if someone searches for the real bug.
|
|
Assignee | |
Updated•15 years ago
|
Blocks: 525189
Keywords: regression
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [mozmill-test-failure]
|
|
Assignee | |
Comment 8•14 years ago
|
||
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Preferences → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: preferences → mozmill-tests
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•