Closed Bug 554988 Opened 15 years ago Closed 15 years ago

[shared module] Refactor preferencesDialog class to make handling less error prone

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-doc-complete])

Attachments

(3 files)

The current code for the preference dialog has been written a long time before and is not quiet the best and reliable one. I will work on refactoring it to make it much less error prone.
Whiteboard: [mozmill-test-failure]
Component: Preferences → Mozmill
Product: Firefox → Testing
QA Contact: preferences → mozmill
Attached patch Patch v1 (default) (deleted) — Splinter Review
This has been gotten bigger as I thought. But now we hopefully shouldn't fail anymore inside the preferences dialog, especially when switching panes. Further work for sub dialogs should be done later.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #434947 - Flags: review?(anthony.s.hughes)
Whiteboard: [mozmill-doc-needed]
Attachment #434947 - Flags: review?(anthony.s.hughes) → review+
No longer blocks: 527983
Anthony will run the whole test-run on Linux now and will report back if no regressions have been introduced.
Attached image Test results (deleted) —
Here is a screenshot detailing the difference in results before and after patching. I did 10 test runs (5 before and 5 after patching). Henrik, can you please evaluate these results and correlate them to your findings.
Anthony, you should run the tests with --show-errors to see the details of a failure. Any test which doesn't use the preferences dialog do not have to be obeyed. With the exception details it's easy to find out if it is related to that patch or not. Thanks.
Attached patch Patch v1 (mozilla1.9.1) (deleted) — Splinter Review
I can't see any problems with the patch for the default branch on OS X and Windows. This one is an updated version for 1.9.1.
Attachment #435176 - Flags: review?(anthony.s.hughes)
Attachment #435176 - Flags: review?(anthony.s.hughes) → review+
Did a test run with the patch on Linux 1.9.1. I was unable to see any regressions with this patch. r+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-doc-needed] → [mozmill-doc-complete]
Summary: [shared-module] Refactor preferencesDialog class to make handling less error prone → [shared module] Refactor preferencesDialog class to make handling less error prone
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill → Mozmill Tests
Product: Testing → Mozilla QA
QA Contact: mozmill → mozmill-tests
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: