Closed
Bug 555690
Opened 15 years ago
Closed 14 years ago
ThreadData::StartTracking should use #else
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
312 bool ThreadData::StartTracking(bool status) {
313 #ifndef TRACK_ALL_TASK_OBJECTS
314 return false; // Not compiled in.
315 #endif
coverity would love for the rest of this function to be in a #else
317 if (!status) {
318 AutoLock lock(list_lock_);
319 DCHECK(status_ == ACTIVE || status_ == SHUTDOWN);
320 status_ = SHUTDOWN;
321 return true;
322 }
323 AutoLock lock(list_lock_);
324 DCHECK(status_ == UNINITIALIZED);
325 CHECK(tls_index_.Initialize(NULL));
326 status_ = ACTIVE;
327 return true;
328 }
Assignee: nobody → timeless
Attachment #435584 -
Flags: review?(jones.chris.g)
|
||
Updated•15 years ago
|
Attachment #435584 -
Flags: review?(jones.chris.g) → review+
|
||
Comment 2•14 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•