Closed
Bug 555692
Opened 15 years ago
Closed 15 years ago
mEnabled is never used in CSPService
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
bsterne
:
review+
|
Details | Diff | Splinter Review |
Defined as a variable in:
* content/base/src/nsCSPService.h (View Hg log or Hg annotations)
o line 56 -- PRBool mEnabled;
Referenced in:
<crickets>
Attachment #435589 -
Flags: review? → review?(dveditz)
|
||
Comment 2•15 years ago
|
||
Although useless now I'm pretty sure we've got a patch somewhere that connects mEnabled with a global-disabling pref. For whatever reason users might not want the site breakage introduced by CSP (for instance, if they are greasemonkey users and we don't implement a more refined way for addons to loosen restrictions).
|
|
||
Updated•15 years ago
|
Attachment #435589 -
Flags: review?(dveditz) → review?(bsterne)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 435589 [details] [diff] [review]
remove it
dveditz is right. We're not using it now, but we plan to hook it up to the pref service later so that extensions and such could turn it off if they want to. I think this is WONTFIX, but I'll wait for :geekboy to confirm that.
Attachment #435589 -
Flags: review?(bsterne) → review-
|
||
Comment 4•15 years ago
|
||
I think we should remove the unused variable.
nsCSPService.cpp:52 has a similar variable that is actually hooked up to a pref to do this, and I don't recall why a copy was in the .h file too.
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 435589 [details] [diff] [review]
remove it
In that case, r=bsterne for timeless' patch.
Attachment #435589 -
Flags: review- → review+
|
||
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•