Closed
Bug 555706
Opened 15 years ago
Closed 15 years ago
useless null checks of a and b in _cairo_path_fixed_equal
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
204 _cairo_path_fixed_equal (const cairo_path_fixed_t *a,
217 if (a->has_curve_to != b->has_curve_to ||
225 if (a != NULL) {
233 if (b != NULL) {
oh, how could i miss:
246 assert (a != NULL && b != NULL);
|
||
Comment 3•15 years ago
|
||
It's better to submit this kind of stuff upstream directly.
sorry, i'm hoping the maintainer (you) would do that. i have a lot of bugs to file and it takes me too many cycles to find the right upstreams.
|
|
||
Comment 5•15 years ago
|
||
I've pushed this upstream.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Attachment #435606 -
Flags: review?(jmuizelaar)
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•