Closed
Bug 555714
Opened 15 years ago
Closed 15 years ago
crashreporter doesn't compile for i386 Mac OS X when MOZ_IPC is enabled
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: cjones)
References
Details
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•15 years ago
|
||
cjones, can you add expedient ifdefs so that Mac builds?
Assignee: nobody → jones.chris.g
|
Assignee | |
Comment 2•15 years ago
|
||
This error suggests the build was x86-64. See
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/common/mac/macho_walker.cc#71
What should this bug cover?
The host is x86-64, the target is i386 in the build I posted errors from. If crashreporter isn't picking up the target arch correctly, that is a bug.
|
||
Comment 4•15 years ago
|
||
Josh: that's a different bug, bug 491774. (We always compile the dump_syms tool as a host binary, it just currently doesn't compile on 64-bit OS X.)
There will be different build errors if you build natively on i386, presumably.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Quick note: I tried to leave as much code enabled as possible to cut down on #ifdef hell and catch regressions.
Attachment #435777 -
Flags: review?(joshmoz)
Comment on attachment 435777 [details] [diff] [review]
Stub out OOP crashreporter on OS X
WFM
Attachment #435777 -
Flags: review?(joshmoz) → review+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/cc5a27cb8ca3
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•