Closed
Bug 555941
Opened 15 years ago
Closed 14 years ago
[HTML5] Split HILO_ACCEL into a separate class
Categories
(Core :: DOM: HTML Parser, defect, P4)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(2 files)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
sicking
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
nsHtml5NamedCharacters has a member called HILO_ACCEL. This poses two problems:
1) It's ugly in C++.
2) Having HILO_ACCEL and the named character tables in the same class makes the Java source fail to compile with java.
Therefore, HILO_ACCEL should be split into a separate class.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #453354 -
Flags: review?(jonas)
Comment on attachment 453353 [details] [diff] [review]
Generator patch
rs=me
Attachment #453353 -
Flags: review?(jonas) → review+
Attachment #453354 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 453354 [details] [diff] [review]
Output patch
Requesting approval. This patch is low-risk, since it merely moves code around. It is desirable, because currently the Gecko copy and the upstream of the HTML5 parser are out of sync and this patch puts them in sync making other fixes simpler.
Attachment #453354 -
Flags: approval2.0?
|
|
Assignee | |
Comment 5•14 years ago
|
||
See also the #whatwg IRC log from
http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
to about the end of that day's log.
|
|
Assignee | |
Comment 6•14 years ago
|
||
(In reply to comment #5)
> See also the #whatwg IRC log from
> http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
> to about the end of that day's log.
Sorry. That comment was supposed to go into another bug.
|
||
Updated•14 years ago
|
Attachment #453354 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•