Closed
Bug 556405
Opened 15 years ago
Closed 15 years ago
Support building qcms on Android
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Some hacks are necessary to build on Android.
Assignee | ||
Comment 1•15 years ago
|
||
These are the changes Vlad made on the mozilla-droid repo to allow qcms to build. http://hg.mozilla.org/users/vladimir_mozilla.com/mozilla-droid/rev/40b367ada1bd
Attachment #436340 -
Flags: review?(jmuizelaar)
Comment 2•15 years ago
|
||
What's the purpose of this hunk?
//XXX: use a better typename
+#ifndef ANDROID
typedef uint32_t __be32;
typedef uint16_t __be16;
+#endif
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> What's the purpose of this hunk?
>
> //XXX: use a better typename
> +#ifndef ANDROID
> typedef uint32_t __be32;
> typedef uint16_t __be16;
> +#endif
Without it, we get:
/fasthome/mikew/moz/mozilla-central/gfx/qcms/iccread.c:29: error: redefinition of typedef '__be32'
/fasthome/mikew/moz/mc-droid-debug/../android-ndk-r3/build/platforms/android-5/arch-arm/usr/include/linux/types.h:24: note: previous declaration of '__be32' was here
/fasthome/mikew/moz/mozilla-central/gfx/qcms/iccread.c:30: error: redefinition of typedef '__be16'
/fasthome/mikew/moz/mc-droid-debug/../android-ndk-r3/build/platforms/android-5/arch-arm/usr/include/linux/types.h:22: note: previous declaration of '__be16' was here
Comment 4•15 years ago
|
||
Comment on attachment 436340 [details] [diff] [review]
Support building qcms on Android
It would be better to rename __be32/16 to be32/16 etc.
Attachment #436340 -
Flags: review?(jmuizelaar) → review-
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #436340 -
Attachment is obsolete: true
Attachment #437088 -
Flags: review?(jmuizelaar)
Updated•15 years ago
|
Attachment #437088 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•