Closed Bug 556458 Opened 14 years ago Closed 14 years ago

Cannot select an item of google suggest by mouse click during composition of MS-IME

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4
Tracking Status
status1.9.2 --- .4-fixed
status1.9.1 --- unaffected

People

(Reporter: masayuki, Assigned: masayuki)

References

()

Details

(Keywords: inputmethod, intl, regression)

Attachments

(2 files, 1 obsolete file)

Attached patch Patch v1.0 (obsolete) (deleted) — Splinter Review
This is a regression of bug 492233.

When I click a text node of an item of google suggest during composition of MS-IME, the item isn't set to the input field.

This is a bug of nsContentEventHandler::OnQueryCharacterAtPoint(). It's looking for the target text frame at the click event but it doesn't check whether the text node is in the focused editor or not.

I think that this should be fixed on Fx3.6 too.

I'll create tests...
Attached patch Patch v1.0 + tests (deleted) — Splinter Review
Just adding to check whether the text node which is content of the found textframe is descendant of mRootContent (editor root) or not.
Attachment #436429 - Attachment is obsolete: true
Attachment #436483 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/489fde3195cd
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attached patch Patch v1.0 for 1.9.2 branch (deleted) — Splinter Review
This is a regression on major service and this patch doesn't have risk, so, we should fix this bug on branch too.
Attachment #436638 - Flags: approval1.9.2.4?
Comment on attachment 436638 [details] [diff] [review]
Patch v1.0 for 1.9.2 branch

a=beltzner for mozilla-1.9.2.4
Attachment #436638 - Flags: approval1.9.2.4? → approval1.9.2.4+
Target Milestone: --- → mozilla1.9.3a4
Masayuki, can you check your test into 1.9.2 as well? I don't see it in your 1.9.2 patch.
(In reply to comment #5)
> Masayuki, can you check your test into 1.9.2 as well? I don't see it in your
> 1.9.2 patch.

The tests need new APIs, so, we cannot port the tests to 1.9.2 branch.
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: