Closed Bug 556767 (semantics) Opened 15 years ago Closed 15 years ago

Improve/Complete implementation of <semantics/>

Categories

(Core :: MathML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

This is a meta-bug to track issues related to <semantics/>. Currently, we use CSS to display only the first child. We should probably write a class nsMathMLsemanticsFrame to have a better control on what should be displayed or not. Also, this should probably help having the same behavior as other frames and hence fixing bugs.
Alias: semantics
Keywords: helpwanted
Keywords: meta
Blocks: 21479
I've just tried to implement a NS_NewMathMLsemanticsFrame and it allows to fix bug 468059, bug 512418, bug 523037 and bug 523045. I'll attach a patch when I've made reftests from their testcases.
Attached patch Patch (deleted) — Splinter Review
This patch fixes the four bugs mentioned above as well as the special case of bug 21479 related to <semantics/>.
Attachment #443701 - Flags: review?(roc)
In bug 468059 comment 1 you suggested just creating an nsMathMLContainerFrame. Did that not work? Why did you create a new frame type here?
Actually, I haven't tried to directly use a NS_NewMathMLContainerFrame. I just need nsMathMLsemanticsFrame to get embellished-op data from the first child in TransmitAutomaticData(). Although I can implement a function TransmitAutomaticData in NewMathMLContainerFrame that does this job when mContent->Tag() == semantics_, I find it cleaner to work in a separate class. Also, this class could be useful if one improves the behavior of the <semantics/> element: http://mxr.mozilla.org/mozilla-central/source/layout/mathml/mathml.css#414
Comment on attachment 443701 [details] [diff] [review] Patch That makes sense.
Attachment #443701 - Flags: review?(roc) → review+
Assignee: nobody → fred.wang
No longer depends on: 468059, 512418, 523037, 523045
Keywords: helpwanted, meta
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Depends on: 572899
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: