Closed Bug 556817 Opened 14 years ago Closed 14 years ago

Better detect fields to suggest people

Categories

(Mozilla Labs :: Identity, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

Currently we only guess by checking the input's name. We can do better!
Attached patch v1 (deleted) — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
http://hg.mozilla.org/labs/people/rev/2990ccad08d7
Override satchel/form-autocomplete;1 instead of autocomplete/search;1?name=form-history so that we can get the html input to check various attributes. Always suggest if type=email, and check name/id/rel for maybes. Bump minver to 3.6 as that's when the the input started getting passed to autoCompleteSearch. 

One oddity is that input.type reverted to "text" but getAttribute("type") correctly provided the original "email".
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla Services → Mozilla Labs
Target Milestone: --- → --
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: