Closed
Bug 556930
Opened 15 years ago
Closed 15 years ago
Wrong secret phrase warning shows up when logging in
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
1.3b1
People
(Reporter: Mardak, Assigned: mconnor)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
Bug 545725 doesn't short circuit on the passphrase failure, so the UI needs to know that this is an intermediate failure somehow. Except it's the status bar showing this failure and not the fx-prefs.
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mconnor
Target Milestone: --- → 1.3
|
|
Assignee | |
Comment 1•15 years ago
|
||
This is bigger than I intended it to be, but I'm going to use the new const elsewhere.
Attachment #440240 -
Flags: review?(edilee)
|
Reporter | |
Comment 2•15 years ago
|
||
Comment on attachment 440240 [details] [diff] [review]
v1
Go zpao! ;)
Attachment #440240 -
Flags: review?(edilee) → review?(paul)
|
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 440240 [details] [diff] [review]
v1
>+++ b/source/modules/status.js
>+ if (code == LOGIN_FAILED_NETWORK_ERROR || code == LOGIN_FAILED_SERVER_ERROR)
> this.service = LOGIN_FAILED;
>+ else if (code != LOGIN_SUCCEEDED) // missing/wrong user/pass/pp
>+ this.service = CLIENT_NOT_CONFIGURED;
Mm.. This should be fine other than the corner case from bug 560260 where a totally bogus username (email address) results in a 400 -> SERVER_ERROR.
Attachment #440240 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Yeah, we'll need to fix that bug eventually (soon).
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: 1.3 → 1.3b1
|
||
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•