Closed
Bug 557468
Opened 15 years ago
Closed 14 years ago
No tab drop indicator appears when enabled Tabs over the Navigation Toolbar
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
Firefox 4.0b5
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: alice0775, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [4b1] [fixed by bug 574454])
Attachments
(2 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre ID:20100406003858
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre ID:20100406003858
No tab drop indicator appears when enabled Tabs over the Navigation.
Reproducible: Always
1. Start Minefield with new profile
2. View > Toolbars > "Tabs on Top" checked
3. Open several tabs
4. Dragging over a tab on tabtoolbar
Actual Results:
No tab drop indicator appears
Expected Results:
tab drop indicator appears
Comment 2•15 years ago
|
||
This bug affects Linux and Windows but not OS X.
OS: Windows 7 → All
Hardware: x86 → All
Comment 3•15 years ago
|
||
On my system (WinXP using the XP theme on my system, not browser), with tabs on top, the drop indicator is there, but most of it blends into my blue title bar. One must look very closely, but there is the tip of the arrow showing just below the title bar. It is only a few pixels in height--about the height of the space between the top of a tab and the top of the tab toolbar. Could it be that the drop indicator does not extend into the title bar? If that is the case, could the drop indicator be switched to pointing up from the nav toolbar side instead?
Comment 4•14 years ago
|
||
works for me on XP
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100616 Minefield/3.7a6pre ( .NET CLR 3.5.30729)
(In reply to comment #4)
> works for me on XP
>
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100616
> Minefield/3.7a6pre ( .NET CLR 3.5.30729)
It is probably working for you now that the Firefox button created its own toolbar and now the indicator has somewhere to be drawn.
(In reply to comment #6)
> *** Bug 575573 has been marked as a duplicate of this bug. ***
why dupe ?
Comment 9•14 years ago
|
||
FWIW, this works for me fine on Windows 7 with Aero Glass. Would be really good if we could figure out what's causing it. Only happens to Juan on Vista, f.o.
Whiteboard: [4b1]
Comment 10•14 years ago
|
||
(In reply to comment #9)
> Only happens to Juan on Vista, f.o.
no, happen on Win 7 with basic theme
see com #6, bug575573
fine with aero theme
Comment 11•14 years ago
|
||
(In reply to comment #9)
> Would be really good if we could figure out what's causing it.
As brought out by Ray in (comment #3), when tabs are at top the tab drop indicator is almost invisible (on Win XP, see attachment circled red).
As he mentioned if tabs are on top, maybe the arrow could be shown from below the tab bar.
Or, if the Windows Title bar can be displayed over (which I currently think is a problem for non-aero themed desktops (comment #10)), if the Tab Drop Indicator could be colored differently then the Windows Title bar, it would show up much better (ex: one pixel white border around the Tab drop arrow).
This would also help the Tab Drop indicator show up better on dark colored Persona's (ex: dark persona right side attachment).
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Depends on: 574454
Resolution: --- → FIXED
Whiteboard: [4b1] → [4b1] fixed by bug 574454
Target Milestone: --- → Firefox 4.0b4
Updated•14 years ago
|
OS: All → Windows XP
Updated•14 years ago
|
blocking2.0: ? → ---
Comment 12•14 years ago
|
||
should reopen ?
happen again after https://bugzilla.mozilla.org/show_bug.cgi?id=575870#c72
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 13•14 years ago
|
||
Given the fact that tabs on top is the default setting for Firefox 4.0, users will always run into this problem. Asking for blocking.
Status: REOPENED → NEW
blocking2.0: --- → ?
Target Milestone: Firefox 4.0b4 → ---
Comment 14•14 years ago
|
||
Marking as betaN - can someone please confirm that this is still a problem? Dao, do you see how the checkin referenced in comment 12 would have caused this to happen again?
blocking2.0: ? → betaN+
Whiteboard: [4b1] fixed by bug 574454 → [4b1] [to be fixed by bug 574454]
Reporter | ||
Comment 15•14 years ago
|
||
This problem happens again due to changeset 5704ef94d87f of Bug 575870 .
Because, the patch of Bug 574454 had been backed out by changeset 5704ef94d87f of Bug 575870.
And this problem is not yet fixed on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre ID:20100824040950 .
Comment 16•14 years ago
|
||
seems to be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=575870#c99
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → WORKSFORME
Updated•14 years ago
|
Resolution: WORKSFORME → FIXED
Whiteboard: [4b1] [to be fixed by bug 574454] → [4b1] [fixed by bug 574454]
Comment 17•14 years ago
|
||
Build:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre ( .NET CLR 3.5.30729) Firefox/3.6.8 ID:20100825062325
Comment 18•14 years ago
|
||
(In reply to comment #17)
> Created attachment 469390 [details]
> Latest nightly Tab drop imdicator still 'missing' on latest XP release.
>
> Build:
> Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre (
> .NET CLR 3.5.30729) Firefox/3.6.8 ID:20100825062325
There's some add-on or userChrome.css code messing this up for you.
Comment 19•14 years ago
|
||
(In reply to comment #18)
>
> There's some add-on or userChrome.css code messing this up for you.
Yes if you remove the Title from the Windows "Title" bar, by letting the 'Minefield' button to show, you can see the Tab Drop indicator on the large empty Windows "Title" bar.
It even shows over the upper right Windows 'Minimize, Maximize, and Close' icons,
if this can be done, there should be no problem of displaying it over the Title in the Title bar.
Comment 20•14 years ago
|
||
Dao, do we already have a bug for OS X where the tab drop indicator is cut-off?
Comment 21•14 years ago
|
||
I don't think so.
Comment 22•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100826 Minefield/4.0b5pre
(In reply to comment #20)
> Dao, do we already have a bug for OS X where the tab drop indicator is cut-off?
Filed that as bug 591050.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 4.0b5
You need to log in
before you can comment on or make changes to this bug.
Description
•