Closed
Bug 557496
Opened 15 years ago
Closed 14 years ago
Port Firefox bookmarks tests to SeaMonkey
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a3
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Once bug 498596 switches us to places bookmarks, we also should get tests for those, starting porting the Firefox tests over to SeaMonkey.
Assignee | ||
Comment 1•14 years ago
|
||
This patch adds all the tests that succeed, I spent too many hours trying to make others work, esp. in the browser-chrome area, and I gave up on them for now.
Comment 2•14 years ago
|
||
Comment on attachment 458244 [details] [diff] [review] add those tests that succeed rs+ based on a skim... but >+++ b/suite/common/places/tree.xml >- for (let j = min.value; j <= max.value; ++j) >- nodes.push(resultview.nodeForTreeIndex(j)); >+ if (max.value > -1) >+ for (let j = min.value; j <= max.value; ++j) >+ nodes.push(resultview.nodeForTreeIndex(j)); Was this another patches remnant, or needed for a test here, if so can you please explain it for posterity. (If I find time to actually review the tests, I may steal review from neil; but I would think my rs+ is ok for the test-only changes, especially if they all pass.)
Attachment #458244 -
Flags: review+
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Was this another patches remnant, or needed for a test here, if so can you > please explain it for posterity. Thanks for catching that, it's indeed a remnant, though from testing why some of the not added tests failed. It's not wrong, but it probably doesn't belong there.
Assignee | ||
Updated•14 years ago
|
Blocks: SMPlacesBMarks
No longer depends on: SMPlacesBMarks
Assignee | ||
Updated•14 years ago
|
Attachment #458244 -
Flags: review?(neil)
Assignee | ||
Comment 4•14 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/b9e980d6f85d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Updated•14 years ago
|
Version: unspecified → Trunk
Comment 5•14 years ago
|
||
(In reply to comment #3) > It's not wrong, but it probably doesn't belong there. This |if (max.value > -1)| got pushed anyway. Should we revert it (ftb)? Or try to add it to Firefox too?
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•