Closed
Bug 558576
Opened 15 years ago
Closed 15 years ago
Build broken in libpr0n due to empty includes (vector/algorithm)
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 557000
People
(Reporter: mpk, Unassigned)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Builds on FreeBSD have been broken for about a week. The error message includes:
../../../dist/stl_wrappers/vector:92:12: error: empty filename in #include
../../../dist/stl_wrappers/algorithm:92:12: error: empty filename in #include
The build falsely assumes that MSVC is being used because GCC_VERSION isn't set.
The attached patch should unbreak the build for every non-tier-1 platform that
uses GCC (with the possible exception of SGI's Irix which had GCC_VERSION set
already).
It would be nice to get some feedback from builders using the Intel compiler on
Linux. I hope this patch doesn't cause any problems using said configuration.
Deferring review request until we can be sure this is not the case.
|
Reporter | |
Updated•15 years ago
|
Keywords: regression
Attachment #438283 -
Attachment is patch: true
Attachment #438283 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 1•15 years ago
|
||
Is this issue different than bug 557000?
|
|
Reporter | |
Comment 2•15 years ago
|
||
It's indeed the same issue. And attachment 437811 [details] [diff] [review] from bug 557000 will probably fix it for all platforms once it gets r+ and lands. Thanks for asking, Serge. :-)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•