Closed
Bug 558636
Opened 15 years ago
Closed 15 years ago
Port Bug 528440 [Should skip windows that are closed but not yet destroyed when using nsIWindowMediator] to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
misak.bugzilla
:
review+
misak.bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
From parent bug:
nsIWindowMediator tracks windows until they are destroyed, but there's a brief
period when windows are closed without being destroyed yet. Session restore
should only care for windows that are open and should thus skip windows that
aren't.
I don't think this is relevant for real users, but it likely is relevant for
tests and could in fact be the cause for some intermittent failures we're
seeing.
I ran test on my Fedora 12, no failed test seen.
Attachment #438332 -
Flags: superreview?(neil)
Attachment #438332 -
Flags: review?(neil)
|
||
Updated•15 years ago
|
Attachment #438332 -
Flags: superreview?(neil)
Attachment #438332 -
Flags: superreview+
Attachment #438332 -
Flags: review?(neil)
Attachment #438332 -
Flags: review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 438332 [details] [diff] [review]
patch
>- if (window.__SSi) {
>+ if (window.__SSi && !window.closed) {
Window closing is supposed to delete properties. But just in case, I'd prefer for you to check !window.closed first.
|
Assignee | |
Comment 2•15 years ago
|
||
For checkin, carrying forward r+ and sr+ from Neil.
Attachment #438332 -
Attachment is obsolete: true
Attachment #438370 -
Flags: superreview+
Attachment #438370 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•15 years ago
|
||
checking ping
|
|
Assignee | |
Comment 4•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → seamonkey2.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•