Closed
Bug 558784
Opened 15 years ago
Closed 14 years ago
support JIRA links in see also
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement, P2)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: timeless, Assigned: selsky)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
timello
:
review+
|
Details | Diff | Splinter Review |
steps:
1. load bug 554853
2. copy http://bugs.adobe.com/jira/browse/FB-23384 from comment 0
3. paste it into "Add Bug URLs"
4. press enter
expected results:
JIRA link should be accepted.
|
||
Updated•15 years ago
|
Depends on: bz-seealso
|
||
Updated•15 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #480854 -
Flags: review?(mkanat)
|
|
||
Comment 2•14 years ago
|
||
timello is right in the middle of refactoring this code, so he may be a better reviewer than me at the moment.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #480854 -
Flags: review?(mkanat) → review?(timello)
|
||
Comment 3•14 years ago
|
||
Ok, I'll review this patch as soon as I finish the refactoring bug 593539.
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 480854 [details] [diff] [review]
Add support for detecting JIRA URLs
Hey Matt, sorry for the delay. Now we have to use the new see also code. You should create a Bugzilla/BugUrl/Jira.pm. Use the other bug trackers as example how to implement it.
Attachment #480854 -
Flags: review?(timello) → review-
|
|
Assignee | |
Comment 5•14 years ago
|
||
Attachment #480854 -
Attachment is obsolete: true
Attachment #499228 -
Flags: review?(timello)
|
|
||
Updated•14 years ago
|
Assignee: create-and-change → selsky
Status: NEW → ASSIGNED
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 499228 [details] [diff] [review]
Add support for detecting JIRA URLs, v2
It looks good and it works as expected!
Thanks Matt!
Attachment #499228 -
Flags: review?(timello) → review+
|
|
||
Updated•14 years ago
|
Flags: approval?
|
|
||
Updated•14 years ago
|
Target Milestone: --- → Bugzilla 4.2
|
|
||
Comment 8•14 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/BugUrl.pm
added Bugzilla/BugUrl/JIRA.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 7705.
I renamed "Jira" to "JIRA". Also, forgot to include r/a. Sorry...
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Priority: P1 → P2
You need to log in
before you can comment on or make changes to this bug.
Description
•