Closed
Bug 558954
Opened 15 years ago
Closed 15 years ago
Don't show/hide placeholder if we're about to initialize the editor
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Currently, in nsTextControlFrame::UpdateValueDisplay, we show/hide the placeholder unconditionally, but if we're being called from nsTextControlFrame::EnsureEditorInitializedInternal, we don't need to do that, since that function will do it again after the editor is initialized. This is a small perf win. For example, it can buy us about 2.7% of the total time, and it's totally redundant, so we can remove it.
Attachment #438629 -
Flags: review?(roc)
Attachment #438629 -
Flags: review?(roc) → review+
|
||
Updated•15 years ago
|
OS: Mac OS X → All
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/35aa2569f5b7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•