Closed
Bug 559336
Opened 14 years ago
Closed 14 years ago
oggplay_seek_cleanup leaks trash when oggplay_buffer_new_buffer fails
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
79 oggplay_seek_cleanup(OggPlay* me, ogg_int64_t milliseconds)
96 trash = oggplay_calloc(1, sizeof(OggPlaySeekTrash));
104 if (me->buffer != NULL) {
112 me->buffer = oggplay_buffer_new_buffer(me->buffer->buffer_size);
114 if (me->buffer == NULL)
116 return E_OGGPLAY_OUT_OF_MEMORY;
Attachment #438990 -
Attachment is patch: true
Attachment #438990 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 2•14 years ago
|
||
We don't use liboggplay on trunk any more (bug 556455 will delete it shortly), but it might be worth fixing this on the branches.
|
||
Comment 3•14 years ago
|
||
We've removed liboggplay on trunk. Please reopen this bug if you care about fixing it on branch.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #438990 -
Flags: review?(kinetik)
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•