Closed
Bug 559343
Opened 15 years ago
Closed 14 years ago
cleanup oc_sb_create_plane_mapping
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: kinetik)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, Whiteboard: [sg:nse] correct address passed to memcpy with incorrect type)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
55 static void oc_sb_create_plane_mapping(oc_sb_map _sb_maps[],
95 memset(_sb_maps[sbi][0],0xFF,sizeof(_sb_maps[sbi]));
Event overrun-buffer-arg: Overrun of static array "&_sb_maps[sbi][0]" of size 16 bytes by passing it to a function which indexes it with argument "64U" at byte position 63
|
||
Comment 1•15 years ago
|
||
|
|
||
Comment 2•15 years ago
|
||
The code in question appears valid. I've attached a patch which _should_ be equivalent and should avoid the report, however I have no way to test it to ensure coverity stops reporting a problem.
|
||
Updated•15 years ago
|
Group: core-security
Whiteboard: [sg:nse] correct address passed to memcpy with incorrect type
Comment on attachment 439131 [details] [diff] [review]
Patch to avoid error report.
this is indeed what i expected and what i think coverity expected.
let's push this and if coverity complains i'll apologize in a few months.
Attachment #439131 -
Flags: review+
|
Assignee | |
Comment 4•15 years ago
|
||
This is Tim's patch reformatted to make it easier to track against upstream. If this silences the Coverity warning we can make sure it goes upstream.
Attachment #439131 -
Attachment is obsolete: true
Attachment #442259 -
Flags: review?(chris.double)
|
||
Updated•15 years ago
|
Attachment #442259 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [sg:nse] correct address passed to memcpy with incorrect type → [needs landing] [sg:nse] correct address passed to memcpy with incorrect type
|
||
Updated•15 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing] [sg:nse] correct address passed to memcpy with incorrect type → [sg:nse] correct address passed to memcpy with incorrect type
|
|
Assignee | |
Comment 6•14 years ago
|
||
timeless, can you confirm that this shut Coverity up?
sorry for the delay. This indeed fixed the problem. Gecko upstream was pulled into our world in the middle of May and a Coverity run at the end of May reported this problem no longer existed.
Thanks. Sorry for not getting back to you sooner.
Status: RESOLVED → VERIFIED
|
|
||
Comment 8•14 years ago
|
||
Committed upstream in r17505.
Status: VERIFIED → RESOLVED
Closed: 15 years ago → 14 years ago
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•