Tobias (:Tobbi) Markus Reporter
	Description • 14 years ago

When opening a HTML5 video site with current trunk build of Fennec, I found out that it has no context menu at all.

This is a difference to Firefox, where the context menu contains items like Play, Pause, Restart, Full Screen, Copy video URL, and much more.

I think it should be available on Fennec too (at least the most important of them, keeping in mind that space is limited on mobile)

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 1 • 14 years ago

Madhava ?

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 2 • 14 years ago

related to bug 465839

	Aakash Desai [:aakashd]
	Comment 3 • 14 years ago

We can't really fix the context menu issue until we have controls for the feature, so I'm marking this as dependent on the bug mentioned in comment #2

	Matt Brubeck (:mbrubeck)
	Comment 4 • 14 years ago

As a start, this adds a context menu for video elements with "Share Video" and "Save Video" commands:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#806

We could add Play/Pause, but it would require a little extra code to send messages back to the child process.  I haven't done this yet because Madhava suggested just using single-tap for play/pause.

It looks like full-screen needs more code too.  Firefox uses an HTML page and openDialog to do full-screen:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#807

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 5 • 14 years ago

Comment on attachment 469148 [details] [diff] [review]
part 1

This is a good start.

	Matt Brubeck (:mbrubeck)
	Comment 6 • 14 years ago

Comment on attachment 469148 [details] [diff] [review]
part 1

Pushed: http://hg.mozilla.org/mobile-browser/rev/5543b742f8b3

	Matt Brubeck (:mbrubeck)
	Comment 7 • 14 years ago

Filed followup bug 590719 for play/pause and bug 590715 for fullscreen.

	Aakash Desai [:aakashd]
	Comment 8 • 14 years ago

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre

	Aaron Train [:aaronmt] Assignee
	Comment 9 • 14 years ago

https://litmus.mozilla.org/show_test.cgi?id=12895