Robert Kaiser Reporter
	Description • 15 years ago

Once bug 498596 lands, we can make bookmarks and history use the same set of core places files, like for example the tree implementation and view, or PlacesUIUtils.

See bug 498596 comment #14 for some numbers aligned with this - additionally, it eases maintenance by only needing to update a single set of places files to keep up with Firefox work.

The bookmarks patches already import the new, more complete files in a shared place to make this followup easier.

	Robert Kaiser Reporter
	Comment 1 • 14 years ago

Bug 580656 is now about the to-be-shared new places core, only that part is needed to work on making history use it as well.

	Robert Kaiser Reporter
	Comment 2 • 12 years ago

Neil, i thought you had a shot at this at some time, but I see that we still have controller.js, tree.xml, treeView.js on both places/ and history/ - if those both are used, I think we should at least make this a mentored bug. Neil, would you mentor it?

	neil@parkwaycc.co.uk
	Comment 3 • 12 years ago

(In reply to Robert Kaiser from comment #2)
> Neil, i thought you had a shot at this at some time, but I see that we still
> have controller.js, tree.xml, treeView.js on both places/ and history/ - if
> those both are used, I think we should at least make this a mentored bug.
> Neil, would you mentor it?
I could I suppose. I assume places.css could be shared too?

	Robert Kaiser Reporter
	Comment 4 • 12 years ago

(In reply to neil@parkwaycc.co.uk from comment #3)
> I could I suppose. I assume places.css could be shared too?

Good, thanks, I'll add the entries for this.
On places.css: Yes, probably, I didn't looks through all files in those directories, just caught some major ones I know. Whoever works on this should check what in suite/common/history/ is duplicated in suite/common/places/ (ideally code-wise, not just file-name-wise) and make us use the places/ versions in the history stuff as well.

	Frank-Rainer Grahl (:frg)
	Comment 5 • 7 years ago

Done in Bug 1378089