Closed
Bug 560111
Opened 15 years ago
Closed 7 years ago
Make history use the same core places files as bookmarks
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1378089
People
(Reporter: kairo, Unassigned, Mentored)
References
Details
(Whiteboard: [history][2012 Fall Equinox][lang=js/xul])
Once bug 498596 lands, we can make bookmarks and history use the same set of core places files, like for example the tree implementation and view, or PlacesUIUtils.
See bug 498596 comment #14 for some numbers aligned with this - additionally, it eases maintenance by only needing to update a single set of places files to keep up with Firefox work.
The bookmarks patches already import the new, more complete files in a shared place to make this followup easier.
Updated•15 years ago
|
Version: unspecified → Trunk
Reporter | ||
Comment 1•14 years ago
|
||
Bug 580656 is now about the to-be-shared new places core, only that part is needed to work on making history use it as well.
Reporter | ||
Comment 2•12 years ago
|
||
Neil, i thought you had a shot at this at some time, but I see that we still have controller.js, tree.xml, treeView.js on both places/ and history/ - if those both are used, I think we should at least make this a mentored bug. Neil, would you mentor it?
Comment 3•12 years ago
|
||
(In reply to Robert Kaiser from comment #2)
> Neil, i thought you had a shot at this at some time, but I see that we still
> have controller.js, tree.xml, treeView.js on both places/ and history/ - if
> those both are used, I think we should at least make this a mentored bug.
> Neil, would you mentor it?
I could I suppose. I assume places.css could be shared too?
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #3)
> I could I suppose. I assume places.css could be shared too?
Good, thanks, I'll add the entries for this.
On places.css: Yes, probably, I didn't looks through all files in those directories, just caught some major ones I know. Whoever works on this should check what in suite/common/history/ is duplicated in suite/common/places/ (ideally code-wise, not just file-name-wise) and make us use the places/ versions in the history stuff as well.
Whiteboard: [history][2012 Fall Equinox] → [history][2012 Fall Equinox][mentor=Neil][lang=js/xul]
Assignee | ||
Updated•10 years ago
|
Mentor: neil.corlett
Whiteboard: [history][2012 Fall Equinox][mentor=Neil][lang=js/xul] → [history][2012 Fall Equinox][lang=js/xul]
Comment 5•7 years ago
|
||
Done in Bug 1378089
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•