Closed
Bug 560562
Opened 15 years ago
Closed 15 years ago
Active tab difficult to distinguish from inactive tabs
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.7a5
People
(Reporter: fehe, Assigned: dao)
References
Details
(Keywords: polish, regression)
Attachments
(5 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 BetterPrivacy-1.47 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 BetterPrivacy-1.47 Minefield/3.7a5pre
With the "New Style for Tabs" check-in, it is now difficult toe tell which is active tab -- especially on Windows XP Classic Theme. Please make the active easily distinguishable.
Reproducible: Always
Summary: Active tab difficult to distinguish → Active tab difficult to distinguish from inactive tabs
Comment 1•15 years ago
|
||
Do you have a screenshot of what it looks like under Windows XP Classic?
Updated•15 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
Why is this duped to a near year-old Mac OS X bug when this issue arose from a change committed recently for Windows theme? They are not the same.
Status: RESOLVED → UNCONFIRMED
Keywords: regression
Resolution: DUPLICATE → ---
Summary: Active tab difficult to distinguish from inactive tabs → [Windows XP] Active tab difficult to distinguish from inactive tabs
Comment 5•15 years ago
|
||
this is actually where it should be duped to
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → DUPLICATE
Comment 7•15 years ago
|
||
The thinking was to have the active tab much lighter and the background tabs darker. I may have screwed that up by posting two moderately different styles on the mockups page.
This might be a separate issue still because we wanted to target the major XP themes individually and I don't know if we can do that yet: bug 543910
Comment 8•15 years ago
|
||
Dão, this actually started when tabs were put in the toolbar.
Here's what the active tab looked like prior to landing of bug 549061. The active tab had bolded text, which made it stand out better. It wasn't perfect, but was at least better than it is now.
That said, it looks like bug 543910 is concerned with remedying some of this issue.
Comment 10•15 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 Minefield/3.7a5pre ID:20100420040941
works in the 20100316 Win32 nightly
broken in the 20100317 Win32 nightly
to blame: bug 347930
my bad I didn't report this at the time, but it was so obvious that I assumed a bug would be filed by many others on XP
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 11•15 years ago
|
||
top to bottom:
today
march 17
march 16
after march 16 the difference between tab-color for active non-active and hover: is virtually nil
The bolding that has been removed since has only added to the problem
FYI, the most-right tab is the active one
Assignee | ||
Updated•15 years ago
|
Summary: [Windows XP] Active tab difficult to distinguish from inactive tabs → Active tab difficult to distinguish from inactive tabs
Assignee | ||
Comment 12•15 years ago
|
||
This is on top of the patch in bug 457187.
Assignee | ||
Updated•15 years ago
|
Updated•15 years ago
|
Attachment #440382 -
Flags: review?(gavin.sharp) → review+
Comment 13•15 years ago
|
||
Comment on attachment 440382 [details] [diff] [review]
increase the contrast
rs=me...
Assignee | ||
Comment 14•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Reporter | ||
Comment 15•15 years ago
|
||
Verified Fixed: http://hg.mozilla.org/mozilla-central/rev/33acb0b9b1ec
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100427 Minefield/3.7a5pre ID:20100427232453
Though I feel having a weird-looking monkey sitting on the tab, clanging cymbals, would have been much more visible. :p
Reporter | ||
Comment 16•15 years ago
|
||
I have only one concern with this fix, though. Instead of simply making the active tab lighter, you also made the inactive tabs darker. Was this really necessary?
It just makes the black text on gray background contrast worse. Here I'm thinking of those whose sight is not so good with distinguishing black on gray, and this darkening is heading in the wrong direction.
Comment 17•15 years ago
|
||
this bug is fixed but when TABS ON TOP is selected, it reoccurs. When TABS ON TOP is selected, active tab is difficult to distinguish from inactive tabs. Here is the screenshot:
http://i.imgur.com/tz9yP.jpg
You need to log in
before you can comment on or make changes to this bug.
Description
•