Closed
Bug 56061
Opened 24 years ago
Closed 21 years ago
about:about
Categories
(SeaMonkey :: UI Design, enhancement, P3)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rbs, Assigned: caillon)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bryner
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
RFE to display a clickable list of all the supported about:*
Comment 2•24 years ago
|
||
I'd like to do it. :)
Comment 6•23 years ago
|
||
I can do this, I will make one based on all that is currently in the tree.
Having about:about would certainly make my life easier, I would not need to
write a test document for about by hand.
Keywords: mozilla1.0
Faking it using Mozilla keywords!
http://www.mozilla.org/docs/end-user/keywords.html
Create a bookmark as normal to whatever it is you want
Then go to bookmark properties
set the keyword to
about:about
Now if you type about:about in the location bar mozilla will automagically
follow your link.
I also think this should be included under the Help menu, since it should be
pretty visible in order to be effective.
Comment 10•22 years ago
|
||
-> XP apps.
Someone needs to create content in a patch and checkin.
Not much networking to be done here...
Assignee: gagan → sgehani
Component: Networking → XP Apps
QA Contact: benc → paw
Reporter | ||
Comment 11•22 years ago
|
||
Just stumbled in bug 140034: about:buildconfig
These days, there are so many about:* that it is virtually impossible to
discover/stumble on all of them, let alone remember them. It is getting to the
point that this bug isn't just an 'enhancement' anymore. Not being able to
discover the about:* options means that not being able to use them.
Assignee | ||
Comment 12•22 years ago
|
||
Taking. I just hacked up a quick implementation of this. I'll need to do some
cleaning up before I post an actual patch, but should be out the door relatively
soon.
Assignee | ||
Comment 13•22 years ago
|
||
Okay, I just stumbled across a minor roadblock.
http://lxr.mozilla.org/mozilla/source/caps/src/nsScriptSecurityManager.cpp#1230
prevents me from linking to most about: URLs. What I have will display all
abouts and give you links, but only a couple (about:, about:blank,
about:mozilla) are actually clickable....
Assignee | ||
Comment 14•22 years ago
|
||
This seems to play nicely now.
Assignee | ||
Comment 15•22 years ago
|
||
Comment on attachment 121598 [details] [diff] [review]
First crack at this
Oh, btw: I don't really care much to do work beyond where I have it other than
review comment updates. If someone wants to make this localizable, or figure
out a way to tell if a link is unusable as listed (such as about:cache-entry
which requires ?querystring params), be my guest. I just want to get a review,
super-review, and once I do, I'll get a security review and land this, and any
other work can be done at that point. Unless someone wants to modify the
patch.
>Index: xpfe/global/resources/content/aboutAbout.html
>===================================================================
>+ var referrer;
>+ try {
>+ referrer = Components.classes["@mozilla.org/network/standard-url;1"].createInstance(Components.interfaces.nsIURI);
>+ referrer.spec = "chrome://global/content/aboutAbout.html";
>+ } catch (e) {
>+ referrer = { spec: "chrome://global/content/aboutAbout.html" };
>+ }
The above code snippet was inadvertently left in and should be removed, btw.
Assignee | ||
Comment 16•21 years ago
|
||
Also includes a minor change to caps to allow chrome (resource) uris to link to
about: uris.
Attachment #121598 -
Attachment is obsolete: true
Comment 17•21 years ago
|
||
Comment on attachment 128064 [details] [diff] [review]
Patch
r/sr=darin
this looks good to me. you probably want to get someone more familiar
with xpfe-land like jag to review this as well.
Attachment #128064 -
Flags: superreview+
Assignee | ||
Updated•21 years ago
|
Attachment #128064 -
Flags: review?(bryner)
Updated•21 years ago
|
Attachment #128064 -
Flags: review?(bryner) → review+
Assignee | ||
Comment 18•21 years ago
|
||
Let there be about:about.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 19•21 years ago
|
||
re
- { "about", DenyProtocol },
+ { "about", ChromeProtocol },
and comment 13:
Who made the security review? IIRC, we had exploits in about: and strong
restrictions were the fix.
Assignee | ||
Comment 20•21 years ago
|
||
Darin looked at it, but here's the explanation.
The exploits were because it was set to AllowProtocol meaning the world could
link to about: URIs. This is completely safe because it still restricts the
linking to only ChromeProtocol URIs (only chrome: or resource:)
For reference, the about: exploit bug was bug 91714.
Comment 21•21 years ago
|
||
Yes, it seems to be safe.
Thanks for the answer.
FYI, I was thinking about bug 134315 (and others, IIRC).
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•