Closed
Bug 560653
Opened 15 years ago
Closed 15 years ago
Test browser_privatebrowsing_contextmenu_blockimage.js doesn't run
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.7a5
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .5-fixed |
People
(Reporter: enndeakin, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
When running this test standalone, it outputs no results.
It doesn't cause a problem because the makefile doesn't seem to include the test.
Assignee | ||
Comment 1•15 years ago
|
||
When landing the patch for bug 461625, I had forgot to add the tests to the makefile. The empty test output happens because the test uses localhost:8888 instead of mochi.test:8888.
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #441300 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #441300 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Assignee | ||
Comment 4•15 years ago
|
||
I landed the appropriate fixes for branches as well, so that we can get test coverage on the respective code.
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5e84745c884a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a75be9a6d3fa
I don't think it's essential to land these changes on the 1.9.2.4 branch as well, so I didn't land the patch there.
status1.9.1:
--- → .10-fixed
status1.9.2:
--- → .5-fixed
Assignee | ||
Comment 5•15 years ago
|
||
Backed out from 1.9.1 because it caused another test to fail:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1272321663.1272322146.14949.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1272322188.1272322554.16384.gz
It's probably something which has changed in trunk/1.9.2, which causes the context menu test to not clean up correctly. I'll investigate this if I get more time.
The backout changeset is:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e0d52e1df5c7
status1.9.1:
.10-fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•