From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001008 BuildID: 2000100820 can not delete an account imported from Outlook or Outlook Express, because delete button is disabled in the Account Settings dialog Reproducible: Always Steps to Reproduce: 1. Open mail window 2. import account from Outlook, if it is not imported 3. Choose "Edit"/"Mail/News Account Settings" 4. Select imported account Actual Results: Delete button is disabled Expected Results: Deleting is allowed for imported accounts

reporter: have you seen this on new builds?

Yes, I still can not delete those accounts on the build 2000103120

setting bug status to New

over to sspitzer

*** Bug 57726 has been marked as a duplicate of this bug. ***

Taking this bug from Seth.

racham, I have a solution for this, but I never implemented it. here it is: a while back I added canDelete to the nsIMsgProtocolInfo interface. and for "none", canDelete is false. AccountManager.js gets the protocol info for the selected server, and disables the delete button based on canDelete. the problem is imported eudora and outlook accounts are also of type "none". to maintain backward compatablility, we need to add canDelete to the nsIMsgIncomingServer interface. this boolean needs to be reflected in the per server prefs. the default value ("mail.server.default.canDelete" in mailnews.js) needs to be false. then we need to fix the import code so that when it creates incoming servers, it sets canDelete to true. we don't need to do anything when we create the "Local Folders" server. the default is correct. the login in AccountManager.js has to be changed to be this: canDelete = protocolInfo.canDelete; if (!canDelete) { canDelete = server.canDelete; } this makes it so if the protocol info says we can't delete, we check that the current server hasn't overridden it. notice, any eudora or outlook servers created before this fix will not be deletable, unless the users edits their prefs.js file. any eudora or outlook servers created after will be deletable. any "Local Folders" created before or after will not be deletable. let me know if you have any questions.

I should have had canDelete as part of the nsIMsgIncomingServer and not the protocol info in the first place. but since we shipped, any changes have to be backwards compatable. oh well, live and learn.

adding andrew to the cc list. he's going to take a crack at it. andrew, see my comments on "2000-12-05 19:04", I've described the entire fix.

I've attached a patch, but I'd like to get some third party testing on it. I don't have Outlook or Eudora handy, but it should work (famous last words :).

I'll test & review the fix. I hope to land it today. andrew, thanks for yet another patch!

taking from racham while I test and review.

the patch looks ok, but I want to test it. that will have to wait until tomorrow. the same bug exists for "canDuplicate". we will not be able to duplicate imported accounts. do we want the user to be able to duplicate imported accounts? (my guess is yes.) adding nbaca and jglick for comments.

marking nsbeta1+ and moving to mozilla0.8 milestone. It would be great if this patch works out.

I'll try to land this patch today. It looks correct, I just need to test it. thanks to andrew for being patient.

sorry, this will slide another couple of days. eta on a landing, thursday dec 21.

change "protocolInfo" to "protocolinfo" in AccountManager.js, and it all works fine. r=sspitzer, bienvenu, can you sr=?

sr = bienvenu, as long as protocolInfo->protocolinfo.

I've made that correction and checked it in. thanks again andrew.

note to qa: local folders should still not be deletable. any newly imported accounts should be deletable. previously imported accounts are still not deletable. see #63554

Build 2001-01-2204: NT4, Mac 9.04 Verified Fixed, using Outlook Express and Eudora.