Closed Bug 561011 Opened 15 years ago Closed 14 years ago

"Assertion failure: JSVAL_IS_VOID(lval)" involving sharps and "with"

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
blocking2.0 --- beta2+

People

(Reporter: jruderman, Assigned: brendan)

References

Details

(Keywords: assertion, regression, testcase, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

var a = #1=[#1#]; with ({}) { var b; } Assertion failure: JSVAL_IS_VOID(lval), at ../jsops.cpp:3476 Testing using TM branch rev 5b05b75cd402.
autoBisect shows this is probably related to bug 514981: The first bad revision is: changeset: 32201:c19b0d06d076 user: Brendan Eich date: Wed Sep 09 20:21:15 2009 -0700 summary: Bug 514981 - JSStackFrame::sharp{Array,Depth} should be locals allocated due to #n[#=] usage (r=igor).
Blocks: 514981
Keywords: regression
Attached patch proposed fix (obsolete) (deleted) — Splinter Review
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #440707 - Flags: review?(mrbkap)
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a5
blocking2.0: --- → beta1+
Attachment #440707 - Flags: review?(mrbkap) → review+
(In reply to comment #2) > Created an attachment (id=440707) [details] > proposed fix This was checked in to TM, thanks Brendan! http://hg.mozilla.org/tracemonkey/rev/1af19eedbde2
Whiteboard: fixed-in-tracemonkey
This is causing the following test to fail: var o = { p: 1 }; with (o) { var p = 2; } assertEq(o.p, 2); Three failures total, but the second's fallout from the first, and the third is likely duplicative of the first, as far as the eventual fix is likely concerned. REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/tracemonkey-macosx-debug-unittest-jsreftest/build/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-185485.js | Section 2 of test - Expected value '2', Actual value '1' item 2 REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/tracemonkey-macosx-debug-unittest-jsreftest/build/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-185485.js | Section 3 of test - Expected value '2', Actual value '1' item 3 REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/tracemonkey-macosx-debug-unittest-jsreftest/build/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-185485.js | Section 5 of test - Expected value 'function () {NL}', Actual value '0' item 5
Assignee: brendan → jwalden+bmo
OS: All → Mac OS X
Priority: P1 → --
Hardware: All → x86
Target Milestone: mozilla1.9.3a5 → ---
Whiteboard: fixed-in-tracemonkey
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This was backed out of tm. /be
Assignee: jwalden+bmo → brendan
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
oops, sorry.
Attached patch fix, take two (deleted) — Splinter Review
Attachment #441697 - Flags: review?(mrbkap)
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a5
Attachment #440707 - Attachment is obsolete: true
Attachment #440707 - Flags: review+
Attachment #441697 - Flags: review?(mrbkap) → review+
Whiteboard: fixed-in-tracemonkey
blocking2.0: beta1+ → beta2+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: