Closed
Bug 561471
Opened 15 years ago
Closed 14 years ago
Add support for Android to configure.in
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This should be pretty similar to the js configure.in changes for android.
Attachment #441169 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•15 years ago
|
Severity: normal → enhancement
OS: Linux → Android
Hardware: x86 → All
Comment 1•14 years ago
|
||
Comment on attachment 441169 [details] [diff] [review]
Add support for Android to configure.in
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>+
>+ dnl set up the various flags, but only if they're not specified earlier
This comment seems to be a lie.
>+ CPPFLAGS="-I$android_platform/usr/include $CPPFLAGS"
>+ CFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fno-short-enums -fno-exceptions -march=armv5te -mthumb-interwork $CFLAGS"
>+ CXXFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fno-short-enums -fno-exceptions -march=armv5te -mthumb-interwork $CXXFLAGS"
>+ AC_SUBST(ANDROID_NDK)
>+ AC_SUBST(ANDROID_TOOLCHAIN)
>+ AC_SUBST(ANDROID_PLATFORM)
>+ AC_SUBST(ANDROID_SDK)
>+ AC_SUBST(ANDROID_TOOLS)
Usually we stick all the AC_SUBST lines together down near the bottom of the file. I'm not actually sure if that impacts how it works or not.
>@@ -4330,7 +4448,9 @@ if test "$ac_cv_thread_keyword" = yes; t
> :
> ;;
> *)
>- AC_DEFINE(HAVE_THREAD_TLS_KEYWORD)
>+ if test "$OS_TARGET" != Android; then
>+ AC_DEFINE(HAVE_THREAD_TLS_KEYWORD)
>+ fi
Just change the existing case statement to case "${target}" in, and change mips* to mips*-*, then you can slip an android case into the existing flow.
r=me with those changes.
Attachment #441169 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•