Closed
Bug 561596
Opened 15 years ago
Closed 15 years ago
[OS/2]New gfxutils library does not export symbols
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dave.r.yeo, Assigned: dave.r.yeo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ventnor.bugzilla
:
review+
|
Details | Diff | Splinter Review |
Bug #544099 included splitting off a new library, gfxutils which resulted in missing symbol errors when linking gklayout.dll. Static builds linked fine.
This turns out to be a declspec(export) problem which seems to only affect OS/2.
This simple patch fixes the build here. I don't see how this might hurt other systems but have not tested it on anything besides OS/2.
Asking Mike for review as he created the new library.
Attachment #441325 -
Flags: review?(ventnor.bugzilla)
Comment 2•15 years ago
|
||
If this only affects OS/2, could you wrap it with an if or ifdef of some kind to make it only apply to OS/2?
Comment 3•15 years ago
|
||
Actually, forget it. It's one harmless line.
Updated•15 years ago
|
Attachment #441325 -
Flags: review?(ventnor.bugzilla) → review+
(In reply to comment #3)
> Actually, forget it. It's one harmless line.
I didn't bother wrapping it since it is unwrapped in mozilla/gfx/thebes/src/Makefile.in. I'm a little surprised that Windows also doesn't need it.
Thanks for the review.
Whiteboard: checkin needed
Updated•15 years ago
|
Comment 5•15 years ago
|
||
Comment 6•15 years ago
|
||
Pretty sure that this is causing bug 566049
Comment 7•15 years ago
|
||
As discussed in that bug 566049 Mike's assessment was not correct. Since this checkin was only after that bug it would have been surprising...
You need to log in
before you can comment on or make changes to this bug.
Description
•